Skip to content

Update FDC emulator to v3.3.4#10278

Closed
fredzqm wants to merge 1 commit intomainfrom
fdc-emulator/fredzqm/2026-04-07
Closed

Update FDC emulator to v3.3.4#10278
fredzqm wants to merge 1 commit intomainfrom
fdc-emulator/fredzqm/2026-04-07

Conversation

@fredzqm
Copy link
Copy Markdown
Contributor

@fredzqm fredzqm commented Apr 7, 2026

Description

Scenarios Tested

Sample Commands

@fredzqm fredzqm closed this Apr 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md to document a Firebase Data Connect local toolkit update to v3.3.4 and a fix for Angular SDK generation. However, the actual code changes for the version bump are missing from the PR, and the PR description does not follow the repository's required format. Feedback also includes a suggestion to remove redundant phrasing in the changelog and a request to verify if related command logic needs to be updated for the new SDK target.

@@ -1 +1,3 @@
- Updated the Firebase Data Connect local toolkit to v3.3.4, which includes the following changes:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request title and this changelog entry indicate an update to the Firebase Data Connect local toolkit to v3.3.4, but the actual code changes (e.g., version bump in package.json or a version constant file) are missing from this PR.

Additionally, the PR description is empty, which violates the repository style guide requiring ### Description, ### Scenarios Tested, and ### Sample Commands.

References
  1. The repository style guide requires PR descriptions to include specific sections like Description, Scenarios Tested, and Sample Commands to provide context and verification of changes. (link)

@@ -1 +1,3 @@
- Updated the Firebase Data Connect local toolkit to v3.3.4, which includes the following changes:
- [fixed] Fixed an issue where Angular SDK generation would fail.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing [fixed] Fixed is redundant and inconsistent with the existing changelog entries. Furthermore, if this update introduces a new angularSdk target, please verify if src/commands/dataconnect-sdk-generate.ts needs to be updated to include it in the loadAllWithSDKs filter, as it currently only checks for other SDK types.

Suggested change
- [fixed] Fixed an issue where Angular SDK generation would fail.
- Fixed an issue where Angular SDK generation would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants