Skip to content

release #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiminnimij merged 2 commits into from
Mar 2, 2026
Merged

release #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5381584
:bug: delete 값 exhibition의 delete 유무로 변경
jiminnimij Mar 2, 2026
181e1df
Merge pull request #130 from ewha-exhibition/fix/SCRUM-92-guestbook-d…
jiminnimij Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/example/tikitaka/domain/post/dto/PostCard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static PostCard of(Post post, List<String> imageUrls) {
imageUrls == null?0:imageUrls.size(),
post.getExhibition().getExhibitionId(),
imageUrls,
post.isDeleted()
post.getExhibition().getIsDeleted()
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The change to populate PostCard's isDeleted field solely with the Exhibition's deleted status introduces a security risk. Deleted posts may be incorrectly marked as active if their parent Exhibition is still active, potentially leading to unauthorized data exposure and broken access control. The PostCard's deleted status should logically consider both the Post's and Exhibition's deletion status. If either is deleted, the PostCard should be considered deleted.

Suggested change
post.getExhibition().getIsDeleted()
post.isDeleted()

);
}
}
Loading