Conversation
…elete [Fix] delete 값 exhibition의 delete 유무로 변경
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 PostCard DTO에서 삭제 상태를 가져오는 방식의 논리적 오류를 해결합니다. PostCard가 연관된 Exhibition의 삭제 상태를 정확하게 반영하도록 하여 데이터의 정확성을 높이는 데 중점을 둡니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR changes the logic for determining the isDeleted status of PostCard by switching from the Post's own deleted status to that of the associated Exhibition. This introduces a security vulnerability where deleted posts may be inadvertently exposed to users if their associated Exhibition is still active, potentially leading to unauthorized data exposure and broken access control. The current implementation might incorrectly mark a PostCard as not deleted even if the Post itself is deleted, as it now solely relies on the Exhibition's deleted status.
| post.getExhibition().getExhibitionId(), | ||
| imageUrls, | ||
| post.isDeleted() | ||
| post.getExhibition().getIsDeleted() |
There was a problem hiding this comment.
The change to populate PostCard's isDeleted field solely with the Exhibition's deleted status introduces a security risk. Deleted posts may be incorrectly marked as active if their parent Exhibition is still active, potentially leading to unauthorized data exposure and broken access control. The PostCard's deleted status should logically consider both the Post's and Exhibition's deletion status. If either is deleted, the PostCard should be considered deleted.
| post.getExhibition().getIsDeleted() | |
| post.isDeleted() |
#️⃣ 연관된 이슈
#️⃣ 작업 내용
#️⃣ 테스트 결과
#️⃣ 변경 사항 체크리스트
#️⃣ 스크린샷 (선택)
#️⃣ 리뷰 요구사항 (선택)
📎 참고 자료 (선택)