Skip to content

release#131

Merged
jiminnimij merged 2 commits intomainfrom
develop
Mar 2, 2026
Merged

release#131
jiminnimij merged 2 commits intomainfrom
develop

Conversation

@jiminnimij
Copy link
Copy Markdown
Member

#️⃣ 연관된 이슈

관련된 이슈 번호를 적어주세요. 예: #이슈번호

#️⃣ 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요. (이미지 첨부 가능)

#️⃣ 테스트 결과

코드 변경에 대해 테스트를 수행한 결과를 요약해주세요. 예: 모든 테스트 통과 여부, 새로 작성한 테스트 케이스 등

#️⃣ 변경 사항 체크리스트

  • 코드에 영향이 있는 모든 부분에 대한 테스트를 작성하고 실행했나요?
  • 문서를 작성하거나 수정했나요? (필요한 경우)
  • 코드 컨벤션에 따라 코드를 작성했나요?
  • 본 PR에서 발생할 수 있는 모든 의존성 문제가 해결되었나요?

#️⃣ 스크린샷 (선택)

관련된 스크린샷이 있다면 여기에 첨부해주세요.

#️⃣ 리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.
예시: 이 부분의 코드가 잘 작동하는지 테스트해 주실 수 있나요?

📎 참고 자료 (선택)

관련 문서, 스크린샷, 또는 예시 등이 있다면 여기에 첨부해주세요

@jiminnimij jiminnimij merged commit 64c15e0 into main Mar 2, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 PostCard DTO에서 삭제 상태를 가져오는 방식의 논리적 오류를 해결합니다. PostCard가 연관된 Exhibition의 삭제 상태를 정확하게 반영하도록 하여 데이터의 정확성을 높이는 데 중점을 둡니다.

Highlights

  • PostCard DTO의 삭제 상태 로직 수정: PostCard DTO에서 게시물(Post)의 삭제 상태를 가져오는 대신, 게시물과 연관된 전시회(Exhibition)의 삭제 상태를 참조하도록 수정되었습니다. 이는 데이터 일관성을 보장합니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/example/tikitaka/domain/post/dto/PostCard.java
    • isDeleted 플래그의 출처를 변경했습니다.
Activity
  • 현재까지 기록된 활동이 없습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR changes the logic for determining the isDeleted status of PostCard by switching from the Post's own deleted status to that of the associated Exhibition. This introduces a security vulnerability where deleted posts may be inadvertently exposed to users if their associated Exhibition is still active, potentially leading to unauthorized data exposure and broken access control. The current implementation might incorrectly mark a PostCard as not deleted even if the Post itself is deleted, as it now solely relies on the Exhibition's deleted status.

post.getExhibition().getExhibitionId(),
imageUrls,
post.isDeleted()
post.getExhibition().getIsDeleted()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The change to populate PostCard's isDeleted field solely with the Exhibition's deleted status introduces a security risk. Deleted posts may be incorrectly marked as active if their parent Exhibition is still active, potentially leading to unauthorized data exposure and broken access control. The PostCard's deleted status should logically consider both the Post's and Exhibition's deletion status. If either is deleted, the PostCard should be considered deleted.

Suggested change
post.getExhibition().getIsDeleted()
post.isDeleted()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant