Merged
Conversation
Contributor
|
@michaelficarra can you merge this pr? |
Member
|
Why is there a dependency on esprima in the first place? |
Contributor
Contributor
|
Also this PR is depends on 4.x version |
Member
|
@sanex3339 That would be a dev dependency, but it's a regular dependency. I see now though, it's used in the CLI: https://github.com/estools/escodegen/blob/master/bin/escodegen.js. I doubt anybody uses the CLI for anything. |
Contributor
|
Anyway, modify of CLI script is not the task of this PR. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to use a newer version of esprima in their root node_modules and make sure that escodegen uses that version, rather than its bundled 3.x version.
Closes #366
Relates to #391