add support for optional catch binding#383
Closed
cixel wants to merge 2 commits intoestools:masterfrom
cixel:382-optional-catch-binding
Closed
add support for optional catch binding#383cixel wants to merge 2 commits intoestools:masterfrom cixel:382-optional-catch-binding
cixel wants to merge 2 commits intoestools:masterfrom
cixel:382-optional-catch-binding
Conversation
Contributor
|
Any update on this? |
Contributor
This was referenced Jan 3, 2020
Closed
Merged
Contributor
|
#398 is merged |
Contributor
|
If here will be no actions in the next few hours, i'll recreate this PR with updated |
Author
|
Sorry, I've been away. It may be simplest for you to recreate the PR, I haven't touched this stuff in a while. |
Contributor
|
Yep. I already did |
Author
|
Good stuff. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #382.
Tests rely on esprima 1953 or they will throw early:
This PR can hibernate until there's progress on esprima's end, and until esprima dependency version bumps to 4.x+.