Skip to content

Optimize MessageBus::Implementation#decode_channel_name method #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moberegger wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

Optimize MessageBus::Implementation#decode_channel_name method #384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad9e6d
Optimize MessageBus::Implementation#decode_channel_name
moberegger Apr 1, 2026
3fe4370
Use ENCODE_SITE_TOKEN_SIZE constant instead of magic number
moberegger Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/message_bus.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,7 @@ def client_message_filters
private

ENCODE_SITE_TOKEN = "$|$"
ENCODE_SITE_TOKEN_SIZE = ENCODE_SITE_TOKEN.bytesize

# encode channel name to include site
def encode_channel_name(channel, site_id = nil)
Expand All @@ -638,7 +639,14 @@ def encode_channel_name(channel, site_id = nil)
end

def decode_channel_name(channel)
channel.split(ENCODE_SITE_TOKEN)
if (idx = channel.byteindex(ENCODE_SITE_TOKEN))
[
channel.byteslice(0, idx),
channel.byteslice(idx + ENCODE_SITE_TOKEN_SIZE, channel.bytesize - idx - ENCODE_SITE_TOKEN_SIZE)
]
else
[channel, nil]
end
end

def global?(channel)
Expand Down
Loading