Optimize MessageBus::Implementation#decode_channel_name method#384
Open
moberegger wants to merge 2 commits intodiscourse:mainfrom
Open
Optimize MessageBus::Implementation#decode_channel_name method#384moberegger wants to merge 2 commits intodiscourse:mainfrom
MessageBus::Implementation#decode_channel_name method#384moberegger wants to merge 2 commits intodiscourse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another hotspot showing up in our production profiles.
This PR replaces the
channel.split(ENCODE_SITE_TOKEN)with a two-branch approach. It first usesbyteindex(to skip character-encoding boundary checks) to check for the"$|$"site token.When no site token is found:
splitentirely and simply return[channel, nil]. This eliminates both the array and substring allocations thatsplitwould produce.When a site token is found:
byteindextoken position, usebytesliceto extract the channel and site_id directly. This is faster thansplitbecause it scans the string only once and I believe also skips character-encoding boundary checks.byteslicepreserves the source string's encoding, so non-ASCII channel names should be handled correctly.Some benchmarks against
decode_channel_name.Without a site ID
With a site ID