Skip to content

test: add regression coverage for hex literals #19651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sundy-li wants to merge 3 commits into from
Closed

test: add regression coverage for hex literals #19651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5e3d73
fix(ast): treat X'...' as binary literal (#19600)
sundy-li Mar 30, 2026
7ee7a41
fix(ast): clean binary literal rebase duplicates
sundy-li Apr 1, 2026
069b06a
test(ast): cover malformed and arithmetic hex literals
sundy-li Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/query/ast/tests/it/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,6 +1560,7 @@ fn test_expr_error() {
"#,
r#"CAST(1 AS STRING) ESCAPE '$'"#,
r#"1 + 1 ESCAPE '$'"#,
r#"x'ABC'"#,
];

for case in cases {
Expand Down
13 changes: 13 additions & 0 deletions src/query/ast/tests/it/testdata/expr-error.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,16 @@ error:
| while parsing expression


---------- Input ----------
x'ABC'
---------- Output ---------
error:
--> SQL:1:1
|
1 | x'ABC'
| ^^^^^^
| |
| expecting `<LiteralString>`, '<LiteralCodeString>', '<LiteralInteger>', '<LiteralFloat>', 'TRUE', 'FALSE', or more ...
| while parsing expression


11 changes: 11 additions & 0 deletions tests/sqllogictests/suites/query/functions/binary_format.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
statement ok
drop table if exists fmt_bin

statement ok
set binary_output_format = 'hex'

query TT
select typeof(X'ABCD'), X'ABCD'
----
Binary ABCD

statement error
select X'0A' + 1

statement ok
create table fmt_bin(id int, v binary)

Expand Down
Loading