test: add regression coverage for hex literals#19651
Closed
sundy-li wants to merge 3 commits intodatabendlabs:mainfrom
Closed
test: add regression coverage for hex literals#19651sundy-li wants to merge 3 commits intodatabendlabs:mainfrom
sundy-li wants to merge 3 commits intodatabendlabs:mainfrom
Conversation
Contributor
|
This pull request's title is not fulfill the requirements. @sundy-li please update it 🙏. Valid format: Valid types:
|
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Fixes #19600
Core
X'...'binary-literal behavior is already present onmain; this follow-up adds regression coverage that was still missing:x'ABC'X'0A'stays binary and is rejected by numeric arithmeticTests
Validation run:
cargo test -p databend-common-ast --test it parser::test_exprcargo check -p databend-common-sql --libcargo clippy -p databend-common-ast --all-targets -p databend-common-sql --lib -- -D warningsAdded but not executed locally:
tests/sqllogictests/suites/query/functions/binary_format.testType of change
This change is