Skip to content

test: add regression coverage for hex literals#19651

Closed
sundy-li wants to merge 3 commits intodatabendlabs:mainfrom
sundy-li:pr-fix-19600-20260401
Closed

test: add regression coverage for hex literals#19651
sundy-li wants to merge 3 commits intodatabendlabs:mainfrom
sundy-li:pr-fix-19600-20260401

Conversation

@sundy-li
Copy link
Copy Markdown
Member

@sundy-li sundy-li commented Apr 1, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Fixes #19600

Core X'...' binary-literal behavior is already present on main; this follow-up adds regression coverage that was still missing:

  • parser coverage for malformed odd-length hex literals like x'ABC'
  • sqllogictest coverage that X'0A' stays binary and is rejected by numeric arithmetic

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Pair with the reviewer to explain why

Validation run:

  • cargo test -p databend-common-ast --test it parser::test_expr
  • cargo check -p databend-common-sql --lib
  • cargo clippy -p databend-common-ast --all-targets -p databend-common-sql --lib -- -D warnings

Added but not executed locally:

  • tests/sqllogictests/suites/query/functions/binary_format.test

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This change is Reviewable

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

This pull request's title is not fulfill the requirements. @sundy-li please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@sundy-li sundy-li added the agent-reviewable Ready for agent review label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🤖 CI Job Analysis

Workflow: 23826258858

📊 Summary

  • Total Jobs: 86
  • Failed Jobs: 8
  • Retryable: 0
  • Code Issues: 8

NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • linux / sqllogic / standalone_minio (query, hybrid, native): Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, http, parquet): Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, hybrid, parquet): Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, http, native): Not retryable (Code/Test)
  • linux / sqllogic / cluster (query, 4c, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / cluster (query, 4c, http): Not retryable (Code/Test)
  • linux / sqllogic / standalone (query, 4c, http): Not retryable (Code/Test)
  • linux / sqllogic / standalone (query, 4c, hybrid): Not retryable (Code/Test)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

@sundy-li sundy-li closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-reviewable Ready for agent review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Incorrect implementation of Hex Literal X'...' (Inconsistent with SQL Standard)

1 participant