Preview transcoding, trim controls, preserve-original#68
Open
magent-cryptograss wants to merge 2 commits intocryptograss:mainfrom
Open
Preview transcoding, trim controls, preserve-original#68magent-cryptograss wants to merge 2 commits intocryptograss:mainfrom
magent-cryptograss wants to merge 2 commits intocryptograss:mainfrom
Conversation
Hook name PageForms::FormPrinterSetup requires method with double underscores (onPageForms__FormPrinterSetup). Also remove static from getResourceModuleNames() since parent PFFormInput has it non-static. Fixes 500 on Special:FormEdit pages.
- Rewrite initVideoPreview() to check delivery-kid for background transcoding status: loads 480p MP4 from IPFS when ready, polls every 10s while processing, falls back to staging URL - Extract renderVideoPreviewAndTrim() shared by both renderGenericForm and renderVideoForm — preview status div, video player, trim controls - Add trim_start/trim_end to save serialization and finalize request - Add "Keep original file" checkbox in renderActions - CSS for trim controls, preview status, preserve label, more-settings
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased cleanly on current main. Adds the frontend pieces for the preview transcoding system (delivery-kid backend already deployed via maybelle-config #77).
initVideoPreview()checks delivery-kid for preview status, loads 480p MP4 from IPFS gateway when ready, polls every 10s during transcoding, falls back to staging URLpreserve_originalin finalize request bodyrenderVideoPreviewAndTrim()method used by both generic and video form pathsSupersedes #66 (which was based on a stale branch).
Test plan