Share video preview and trim across all draft types#69
Merged
jMyles merged 1 commit intocryptograss:productionfrom Mar 25, 2026
Merged
Conversation
Extract renderVideoPreviewAndTrim() as a shared method so that type:other drafts (from Special:UploadContent) get the same video preview player and trim controls that type:video drafts already had. Move trim serialization out of the video-only save block in JS so trim values are saved for all draft types with video files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderVideoPreviewAndTrim()as a shared PHP method used by bothrenderGenericForm(type:other) andrenderVideoForm(type:video)id='rd-hls-info'to the HLS info paragraph for JS updatesPreviously, uploading video through Special:UploadContent (which creates
type: otherdrafts) would show no video preview or trim controls — onlytype: videodrafts had them. Now both form types get the same preview player, trim controls, and trim serialization.This is a clean rebase onto production (replacing PR #68 which had conflicts).
Test plan
type: otherReleaseDraft with a video file — video preview and trim controls should appeartype: videoReleaseDraft — same behavior as before (no regression)