Skip to content

Allow link.OpenExecutable for files without executable bit set #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaunduncan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow link.OpenExecutable for files without executable bit set #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions link/uprobe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"debug/elf"
"errors"
"fmt"
"io/fs"
"os"
"sync"

Expand Down Expand Up @@ -35,8 +34,6 @@ var (
ErrNoSymbol = errors.New("not found")
)

const permExec fs.FileMode = 0111

// Executable defines an executable program on the filesystem.
type Executable struct {
// Path of the executable on the filesystem.
Expand Down Expand Up @@ -113,15 +110,10 @@ func OpenExecutable(path string) (*Executable, error) {
return nil, fmt.Errorf("path cannot be empty")
}

info, err := os.Stat(path)
if err != nil {
if _, err := os.Stat(path); err != nil {
return nil, fmt.Errorf("stat executable: %w", err)
}

if info.Mode()&permExec == 0 {
return nil, fmt.Errorf("file %s is not executable", path)
}

return &Executable{
path: path,
cachedSymbols: make(map[string]symbol),
Expand Down
Loading