Allow link.OpenExecutable for files without executable bit set#1969
Open
shaunduncan wants to merge 1 commit intocilium:mainfrom
Open
Allow link.OpenExecutable for files without executable bit set#1969shaunduncan wants to merge 1 commit intocilium:mainfrom
shaunduncan wants to merge 1 commit intocilium:mainfrom
Conversation
mmat11
reviewed
Mar 23, 2026
mmat11
previously approved these changes
Mar 23, 2026
ti-mo
previously approved these changes
Mar 24, 2026
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Thanks for picking this up! Please squash into one commit when you've addressed the feedback.
This change removes the restriction added in PR cilium#1938 that requires file paths given to link.OpenExecutable() have the executable bit set. This restores the previous behvaior in versions prior to v0.21.0 while also preserving the new capabilities introduced in PR cilium#1938. Signed-off-by: Shaun Duncan <shaun@speedscale.com>
Contributor
Author
|
Hi everyone - I've addressed the feedback, squashed the branch, and re-pushed. Thanks for taking a look! |
Contributor
|
@shaunduncan I believe there's some related test code failing still |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the restriction added in PR #1938 that requires file paths given to link.OpenExecutable() have the executable bit set. This restores the previous behvaior in versions prior to v0.21.0 while also preserving the new capabilities introduced in PR #1938.
This should resolve #1964