Conversation
80c0e21 to
2778f0a
Compare
2778f0a to
01e41cd
Compare
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4931 +/- ##
===========================================
+ Coverage 47.24% 57.66% +10.41%
===========================================
Files 476 557 +81
Lines 46892 60964 +14072
===========================================
+ Hits 22154 35152 +12998
- Misses 24738 25812 +1074 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| /// A message that emits instruction execution details about a call frame | ||
| #[derive(Debug, Clone)] | ||
| pub struct OpcodeExecutionMessage { |
There was a problem hiding this comment.
It might be better to granularize this, because some tracers would need to have the individual operands and stack values instead of a big string; I'm thinking of like a web-based tracer that displays the stack in a more dynamic way, for example.
There was a problem hiding this comment.
Ah, sorry just saw this!
Thats a good idea. I'll make the update ASAP
This pull request implements a new
VirtualMachineTracertrait that emitsVirtualMachineEventsrather than immediately printing the values to stdout.This should allow better customization of event handling.