cli: support BOA_TRACE env flag for VM trace mode#4982
Closed
Flamki wants to merge 1 commit intoboa-dev:mainfrom
Closed
cli: support BOA_TRACE env flag for VM trace mode#4982Flamki wants to merge 1 commit intoboa-dev:mainfrom
Flamki wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4982 +/- ##
===========================================
+ Coverage 47.24% 58.35% +11.11%
===========================================
Files 476 556 +80
Lines 46892 61171 +14279
===========================================
+ Hits 22154 35697 +13543
- Misses 24738 25474 +736 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Kind of superseeded by #4931, and arguably much better since this assumes you have an OS to get env variables, but the other PR is customizable per the host's requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a minimal, first-step observability improvement for #4937.
It adds an opt-in environment toggle for existing VM trace output so tracing can be enabled in non-interactive workflows (scripts/CI/wrappers) without changing source code.
Changes
BOA_TRACEsupport in addition to--trace.BOA_TRACE:1,true,yes,on0,false,no,offBOA_TRACEvalues.--traceoverridesBOA_TRACE.docs/debugging.mdwith usage examples and value rules.Scope
Validation
cargo fmt --all -- --checkcargo test -p boa_cli tests::parse_bool_env_var -- --nocapturecargo clippy -p boa_cli --all-targets --no-deps -- -D warningsPartially addresses #4937.