Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/run-pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pytest
pip install pipreqs
pip install sqlalchemy
pip install pytest-asyncio
pip install -e .
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a better way to get our local quest into the dependency list

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be using poetry to set up the environment from the .lock or .toml files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. pip install -e . does look at the .toml file to set up the local package, but I'll look into other ways


- name: Generate Requirements
run: |
Expand All @@ -39,12 +37,11 @@ jobs:

- name: Install Requirements
run: |
echo quest==0.1.1 > requirements.ignore
grep -v '^quest==' requirements.txt > requirements_clean.txt
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous line wasn't doing anything

mv requirements_clean.txt requirements.txt
pip install -r requirements.txt

- name: Run unit tests
env:
PYTHONPATH: ${{ github.workspace }}/src
run: |
pytest quest_test -o log_cli=true

Expand All @@ -58,7 +55,5 @@ jobs:
run: aws sts get-caller-identity

- name: Run integration tests
env:
PYTHONPATH: ${{ github.workspace }}/src
run: |
pytest quest_test -m "integration" -o log_cli=true
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ python = "^3.11"
[tool.poetry.group.dev.dependencies]
pytest = "^7.4.0"
pytest-asyncio = "^0.21.0"
dotenv = "^0.19.0"

sqlalchemy = { version = "^2.0.36", optional = true }
boto3 = { version = "^1.35.60", optional = true }
Expand Down