Skip to content

quest fix#82

Open
cwebbles wants to merge 13 commits intomainfrom
collin/gha-fix
Open

quest fix#82
cwebbles wants to merge 13 commits intomainfrom
collin/gha-fix

Conversation

@cwebbles
Copy link
Copy Markdown
Contributor

No description provided.

pip install pipreqs
pip install sqlalchemy
pip install pytest-asyncio
pip install -e .
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a better way to get our local quest into the dependency list

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be using poetry to set up the environment from the .lock or .toml files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. pip install -e . does look at the .toml file to set up the local package, but I'll look into other ways

- name: Install Requirements
run: |
echo quest==0.1.1 > requirements.ignore
grep -v '^quest==' requirements.txt > requirements_clean.txt
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous line wasn't doing anything

@cwebbles
Copy link
Copy Markdown
Contributor Author

I wanted to try to make a few adjustments because we are inadvertently adding the 'quest' package from PyPI through pipreqs. Unfortunately pipreqs doesn't provide a way to somehow exclude a package from its search so I just have to manually remove it from the requirements.txt. When we change names, this won't be an issue anymore!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants