Run wal on background change and use system sassc#56
Open
daniromome wants to merge 1 commit intoavanisubbiah:mainfrom
Open
Run wal on background change and use system sassc#56daniromome wants to merge 1 commit intoavanisubbiah:mainfrom
daniromome wants to merge 1 commit intoavanisubbiah:mainfrom
Conversation
Collaborator
|
Please update the readme and the install sass button in prefs (to install sassc and pywal or point to the githubs to install them) |
ardjuh
reviewed
Sep 16, 2022
Comment on lines
+155
to
156
| if (key === "window_bg_color") run_pywal(base_preset.variables[key], wall_path) | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (key === "window_bg_color") run_pywal(base_preset.variables[key], wall_path) | |
| } | |
| } | |
| run_pywal(base_preset.variables[window_bg_color], wall_path) |
Collaborator
Contributor
|
The way this PR checks if I would also suggest adding a check to see if |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Had a few issues getting the tweak to work with the sass installation button, I made it so it uses system-wide sassc and also added automatic run of pywal whenever background changes since pywal color schemes are supported by a handful of applications. Attaching screenshot of what kind of themes could these changes enable
