Skip to content

Run wal on background change and use system sassc#56

Open
daniromome wants to merge 1 commit intoavanisubbiah:mainfrom
daniromome:main
Open

Run wal on background change and use system sassc#56
daniromome wants to merge 1 commit intoavanisubbiah:mainfrom
daniromome:main

Conversation

@daniromome
Copy link
Copy Markdown

Had a few issues getting the tweak to work with the sass installation button, I made it so it uses system-wide sassc and also added automatic run of pywal whenever background changes since pywal color schemes are supported by a handful of applications. Attaching screenshot of what kind of themes could these changes enable
pywall-gnome

This was referenced Sep 15, 2022
@ardjuh
Copy link
Copy Markdown
Collaborator

ardjuh commented Sep 16, 2022

Please update the readme and the install sass button in prefs (to install sassc and pywal or point to the githubs to install them)

Comment on lines +155 to 156
if (key === "window_bg_color") run_pywal(base_preset.variables[key], wall_path)
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (key === "window_bg_color") run_pywal(base_preset.variables[key], wall_path)
}
}
run_pywal(base_preset.variables[window_bg_color], wall_path)

@ardjuh
Copy link
Copy Markdown
Collaborator

ardjuh commented Sep 16, 2022

At a future moment, we can maybe generate a pywal theme and apply it, so it's more coherent with the rest of the theme and has better readability.
image

@aidanlw505
Copy link
Copy Markdown
Contributor

The way this PR checks if wal is installed will cause issues on certain systems because it only checks /usr/bin/wal. It assumes it's installed globally, when some users might install it in their user path. Even when I install it via pip3 with sudo it ends up in /usr/local/bin/wal on Fedora. I would suggest to check in $PATH

I would also suggest adding a check to see if wal should be ran with -l to potentially generate better color pallets for light mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants