Skip to content

Add Pywal theming#62

Merged
FrancescoCaracciolo merged 4 commits intoavanisubbiah:mainfrom
aidanlw505:feature/pywall
Jan 6, 2024
Merged

Add Pywal theming#62
FrancescoCaracciolo merged 4 commits intoavanisubbiah:mainfrom
aidanlw505:feature/pywall

Conversation

@aidanlw505
Copy link
Copy Markdown
Contributor

This is a more complete implementation of #56. It supports light mode by running wal with -l when you don't have dark mode enabled. It also includes an installation button for Pywal via pip3. I couldn't find a good way to check if wal is installed, so as is, the install button is persistent regardless if Pywal is installed. If anyone has suggestions on how to better handle this, just let me know. There is also a toggle to turn on and off Pywal theming. Lastly, I added a section in the README to help users if they've never used Pywal before.

Screenshot from 2022-10-10 00-45-19

Screenshot from 2022-10-10 00-48-13

@ardjuh
Copy link
Copy Markdown
Collaborator

ardjuh commented Oct 12, 2022

Looks quite nice!
On https://lazka.github.io/pgi-docs/Gio-2.0/classes/Subprocess.html you can find a lot of functions to check if pywal is installed.
Something like this should work:

const process = Gio.Subprocess.new(
    ["wal", "--version"],
    Gio.SubprocessFlags.NONE
);
process.wait(null);
return process.get_successful();

@FrancescoCaracciolo
Copy link
Copy Markdown
Collaborator

Fixed conflicts, and checking if pywal is installed, I'm finally merging this

@FrancescoCaracciolo FrancescoCaracciolo merged commit 8222941 into avanisubbiah:main Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants