Skip to content

Fix verify-action-build to try 'npm run start' for actions that use it #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raboof merged 1 commit into from
Apr 5, 2026
+3 −1
Merged

Fix verify-action-build to try 'npm run start' for actions that use it #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion utils/verify-action-build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ def diff_approved_vs_new(
fi

# Build: first try a root-level build script (some repos like gradle/actions use one),
# then try npm/yarn/pnpm build in the build directory, then package, then ncc fallback.
# then try npm/yarn/pnpm build in the build directory, then package, then start, then ncc fallback.
# If the build directory is a subdirectory, copy its output dir to root afterwards.
RUN OUT_DIR=$(cat /out-dir.txt); \
BUILD_DIR=$(cat /build-dir.txt); \
Expand All @@ -869,6 +869,8 @@ def diff_approved_vs_new(
echo "build-step: $RUN_CMD run build (in $BUILD_DIR)" >> /build-info.log; \
elif $RUN_CMD run package 2>/dev/null; then \
echo "build-step: $RUN_CMD run package (in $BUILD_DIR)" >> /build-info.log; \
elif $RUN_CMD run start 2>/dev/null; then \
echo "build-step: $RUN_CMD run start (in $BUILD_DIR)" >> /build-info.log; \
elif npx ncc build --source-map 2>/dev/null; then \
echo "build-step: npx ncc build --source-map (in $BUILD_DIR)" >> /build-info.log; \
fi && \
Expand Down
Loading