Fix verify-action-build to try 'npm run start' for actions that use it#664
Fix verify-action-build to try 'npm run start' for actions that use it#664
Conversation
Some actions like editorconfig-checker/action-editorconfig-checker use "start" as their build script name. The build detection previously only tried "build" and "package" before falling back to a bare `npx ncc build` which fails for TypeScript entry points. Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I literally asked "please check why |
|
@potiuk I don't understand why you assign PRs to me that you are writing. If you want me to review then use that. |
It was just setting reviewers, not assigning. I thought engaged people might be interested in doing reviews here :). That's what we usually do in other projects - letting other people.who we think are interested in reviewing new things. This can also be automated with CODEOWNERS, i am not sure what is the best way here . |
|
Oh that was an honest mistake. To be honest GitHub interface makes it very easy to choose wrong option (happened in a past). Sorry for that |
3 participants
Some actions like editorconfig-checker/action-editorconfig-checker use "start" as their build script name. The build detection previously only tried "build" and "package" before falling back to a bare
npx ncc buildwhich fails for TypeScript entry points.Generated-by: Claude Opus 4.6 (1M context) noreply@anthropic.com