fix: harden ingesting autoscalers around task-count boundaries#19269
Open
Fly-Style wants to merge 3 commits intoapache:masterfrom
Open
fix: harden ingesting autoscalers around task-count boundaries#19269Fly-Style wants to merge 3 commits intoapache:masterfrom
Fly-Style wants to merge 3 commits intoapache:masterfrom
Conversation
taskCount from ioConfig for scale action instead of activeTaskGroups
taskCount from ioConfig for scale action instead of activeTaskGroupstaskCount from ioConfig for scale action instead of activeTaskGroups
4977473 to
746c760
Compare
This comment was marked as outdated.
This comment was marked as outdated.
taskCount from ioConfig for scale action instead of activeTaskGroups
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
taskCountfromioConfigfor scale action calculations instead ofactiveTaskGroups;taskCountoutside the allowed bounds. For both cost-based and lag-based autoscalers, if the currenttaskCountis belowtaskCountMinor abovetaskCountMax, the scaler now returns the nearest valid boundary instead of using the out-of-range value as the scaling baseline. This keeps supervisors within configured limits and avoids inconsistent scaling decisions.This PR has: