Skip to content

Tony/263 add get key to solidlogin#267

Merged
jesscmoore merged 4 commits intodevfrom
tony/263_add_get_key_to_solidlogin
Apr 6, 2026
Merged

Tony/263 add get key to solidlogin#267
jesscmoore merged 4 commits intodevfrom
tony/263_add_get_key_to_solidlogin

Conversation

@tonypioneer
Copy link
Copy Markdown
Collaborator

@tonypioneer tonypioneer commented Apr 5, 2026

Pull Request Details

What issue does this PR address

  • Add get key to SolidLogin if required.

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Build and run the notepod app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@tonypioneer tonypioneer requested a review from jesscmoore April 5, 2026 06:58
@tonypioneer tonypioneer linked an issue Apr 5, 2026 that may be closed by this pull request
10 tasks
Copy link
Copy Markdown
Collaborator

@jesscmoore jesscmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks @tonypioneer

@jesscmoore jesscmoore merged commit 1663bab into dev Apr 6, 2026
20 checks passed
@jesscmoore jesscmoore deleted the tony/263_add_get_key_to_solidlogin branch April 6, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SOLIDUI: add get key to SolidLogin if required

2 participants