-
Notifications
You must be signed in to change notification settings - Fork 2
SOLIDUI: add get key to SolidLogin if required #263
Description
Describe the Bug
Currently
await getKeyFromUserIfRequired(context, childPage);
needs to be run at the start of data fetch routines in notepod/communitypod, after a user has logged in, in order for data to be retrieved. However I would rather not have to provide context and childPage to data fetch routines as it is only needed for this get key process.
Can getKeyFromUserIfRequired() be added to the end of the SolidLogin() function?
Previously this wasn't an issue, as notepod's getOwnNotesList() data fetch function passed context and childpage and called getKeyFromUserIfRequired(context, childPage) before fetching data.
To Reproduce
Steps to reproduce the behavior:
- Login to Notepod or CommunityPod
Screenshots
Expected Behaviour
Data loads on login, after fetching the security key if required.
Context
Where has the issue been observed:
- Android
- Chrome
- iOS
- Linux
- macOS
- Web
- Windows
[Add any other context about the problem here.]
App Version:
Flutter Version:
Closing Criteria
Checklist for closing the issue:
- No errors from
make prep - All tests pass
make qtest - After login, user is prompted for security key if necessary, and data loads.