Fix collision preview showing phantom collisions on low-density tables#13
Open
Fix collision preview showing phantom collisions on low-density tables#13
Conversation
simulate() always pushes a StateUpdate at time=0 as the first replay entry. The first worker call correctly strips it, but subsequent calls included it in the data sent to the main thread. This StateUpdate contains snapshots of every circle, causing the collision preview renderer to show all balls at stale positions — appearing as desynchronized collision indicators that vanish before the actual collisions occur. Strip the StateUpdate from subsequent simulation batches, matching the behavior of the first batch. https://claude.ai/code/session_01RCdxNaKG7Rg4CRMh7kXu7z
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
balls | 0a814b2 | Commit Preview URL Branch Preview URL |
Mar 24 2026, 08:26 PM |
Benchmark Comparison
Overall: +7.78% ✅ Merge base: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulate()always pushes aStateUpdateattime: 0as the first replay entry. The first worker call correctly strips it viashift(), but subsequent calls included it in the data array sent to the main thread.StateUpdatecontains snapshots of every circle, causing the collision preview renderer to match all balls and show them at stale positions — appearing as desynchronized collision indicators that vanish before the actual collisions occur.Test plan
npm test— all 42 tests passnpm run build— clean production buildnpm run devwith 3-5 balls + collision preview enabled; phantom collision indicators should no longer appearhttps://claude.ai/code/session_01RCdxNaKG7Rg4CRMh7kXu7z