[rewrite] Add GradleBestPractices#3401
Conversation
Changes have been made to gradle/wrapper/gradle-wrapper.jar by:
org.openrewrite.gradle.GradleBestPractices
org.openrewrite.gradle.MigrateToGradle9
org.openrewrite.gradle.MigrateToGradle8
org.openrewrite.gradle.UpdateGradleWrapper: {version=8.x, addIfMissing=false}
org.openrewrite.gradle.UpdateGradleWrapper: {version=9.x, addIfMissing=false}
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
pr-gradle-bump
branch
from
5e9ce61 to
738fc59
Compare
| @@ -1,7 +1,8 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-all.zip | |||
There was a problem hiding this comment.
locally not running anymore. Maybe on CI or someone can fix the missing part, thank you.
* Where:
Build file '/Users/vincent.potucek/IdeaProjects/sonarqube/build.gradle' line: 712
* What went wrong:
A problem occurred evaluating root project 'sonarqube'.
> Failed to apply plugin 'com.google.protobuf'.
> Could not get unknown property 'convention' for project ':sonar-core' of type org.gradle.api.Project.
There was a problem hiding this comment.
Moving from Gradle 8 to Gradle 9 has to be checked properly with our full build process.
Very often plugins break (like protobuf in this case) and the whole operation has to be planned.
|
Thanks a lot for your contribution @Pankraz76. |
|
This pull request cannot be taken as is mainly due to the huge change introduced by moving from Gradle 8 to Gradle 9. In any case thanks for the contribution @Pankraz76 I created a Jira to keep track of this upgrade. |
|
Thanks for the feedback. Of course every codebase is unique. What about java migration? This could also help to improve outdated patterns, also this change should not do any harm. Each recipe is individual. |
2 participants
related to:
GradleBestPracticesdiffplug/spotless#2708GradleBestPracticesopensearch-project/OpenSearch#19885