[rewrite] Add RemoveUnusedPrivateMethods#3400
[rewrite] Add RemoveUnusedPrivateMethods#3400Pankraz76 wants to merge 1 commit intoSonarSource:masterfrom
RemoveUnusedPrivateMethods#3400Conversation
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
pr-pr-method-fix
branch
from
ab27c97 to
af06d55
Compare
| import org.sonar.api.ExtensionPoint; | ||
| import org.sonar.api.ce.ComputeEngineSide; | ||
| import org.sonar.ce.common.scanner.ScannerReportReader; | ||
| import org.sonar.ce.task.projectanalysis.analysis.AnalysisMetadataHolder; |
There was a problem hiding this comment.
This is used in fact with the link in the javadoc.
There was a problem hiding this comment.
sorry yes, this is an onboing bug im sorry. Will undo or suppress this file.
|
Thanks for your contribution @Pankraz76! Because we are not going to introduce the rewrite plugin in the codebase, but mainly because there were a few refactoring done here by rewrite that are quite wrong. The plugin did a good job in finding the unused methods, I think they match quite well with what SonarQube spot that you can see here. Those maintainability issues are still open at the moment because our usual approach is to fix them when refactoring or adding more stuff to the classes affected. |
| /** | ||
| * This is the getter used by MyBatis mapper. | ||
| */ | ||
| private String getKee() { |
There was a problem hiding this comment.
These methods are in fact used by MyBatis, the mapping will fail if they are removed.
There was a problem hiding this comment.
will apply suppression so we can fix this together.
|
@matteo-mara-sonarsource build seems broken locally and on ci:
|
2 participants
Part of :
GradleBestPractices#3401