Skip to content

fix: add missing return value #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lash-L merged 1 commit into from
Mar 9, 2026
Merged

fix: add missing return value #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roborock/data/v1/v1_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ def clean_fluid_status(self) -> CleanFluidStatus | None:
value = (self.dss >> 10) & 3
if value == 0:
return None # Feature not supported by this device
return CleanFluidStatus(value)
return None
Comment on lines 400 to 404
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s existing test coverage for DSS-derived status properties (tests/data/v1/test_v1_containers.py), but it currently only asserts the unsupported case where (dss >> 10) & 3 == 0. Since this bug fix changes behavior for non-zero values, please add a test case that sets a dss value with bits 10-11 = 1 or 2 and asserts clean_fluid_status returns the expected CleanFluidStatus.

Copilot uses AI. Check for mistakes.

@property
Expand Down