Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes StatusV2.clean_fluid_status in the v1 data model so it returns a CleanFluidStatus when the device reports a supported/non-zero value (aligning behavior with Status.clean_fluid_status).
Changes:
- Add the missing
return CleanFluidStatus(value)for the non-zero DSS-derived clean fluid status inStatusV2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| value = (self.dss >> 10) & 3 | ||
| if value == 0: | ||
| return None # Feature not supported by this device | ||
| return CleanFluidStatus(value) | ||
| return None |
There was a problem hiding this comment.
There’s existing test coverage for DSS-derived status properties (tests/data/v1/test_v1_containers.py), but it currently only asserts the unsupported case where (dss >> 10) & 3 == 0. Since this bug fix changes behavior for non-zero values, please add a test case that sets a dss value with bits 10-11 = 1 or 2 and asserts clean_fluid_status returns the expected CleanFluidStatus.
Relates to: home-assistant/core#165029