Open
Conversation
vkrasnovyd
force-pushed
the
409-real-enums
branch
from
e64ed7c to
078dbab
Compare
hjanott
requested changes
Mar 23, 2026
Member
There was a problem hiding this comment.
Please do not convert enum[] to text[]. This will make code less generic for go services.
If we need this conversion for the backend-service maybe we can register our enums in psycopg. https://www.psycopg.org/psycopg3/docs/basic/adapt.html#enum-adaptation
| - entitled | ||
| - entitled_present | ||
| - disabled | ||
| id_field: &id_field |
Contributor
Author
There was a problem hiding this comment.
Let's do it in a separate PR, as it will not change the generated schema.
| return trigger_text | ||
|
|
||
| @staticmethod | ||
| def get_initials( |
Member
There was a problem hiding this comment.
I don't understand the purpose of this function by its name. :/
Let's change it and/or write a doc string.
Contributor
Author
There was a problem hiding this comment.
Added a docstring.
| for line in Path(yaml_file).read_text().splitlines(keepends=True) | ||
| ) | ||
| data = yaml.safe_load("".join(yaml_content)) | ||
| with open(yaml_file, "rb") as f: |
This reverts commit 543a35a.
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
vkrasnovyd
force-pushed
the
409-real-enums
branch
from
0307a21 to
a6e76e7
Compare
hjanott
requested changes
Mar 25, 2026
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #409
Additionally to implementing enums:
collection-meta.ymlwith strings. This allowed me to revert the changes inbuild_models_yaml_contentfrom Define collections defaults in collections-meta.yml #411 and parse the collections files separately again;meeting.export_pdf_fontsize;