Open
Conversation
hjanott
requested changes
Mar 23, 2026
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
Also see the general comment in the related meta issue.
Contributor
Author
There is no need for us to register enums - they are already dumped as normal strings by default. For enum arrays I've adjusted database reader.
|
vkrasnovyd
force-pushed
the
409-real-enums
branch
from
34e5727 to
d8a97c4
Compare
hjanott
requested changes
Mar 27, 2026
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
There is good improvements. Especially the new tests.
hjanott
reviewed
Mar 27, 2026
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
hjanott
approved these changes
Mar 27, 2026
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
Also this is done now. Just waiting for the vote service to get fixed.
vkrasnovyd
added
the
waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts backend to the changes in OpenSlides/openslides-meta#424
Needs changes in vote service (OpenSlides/openslides-vote-service#471) .
Database writer is now using the correcponding enum as a type for updating list fields with items.enum.