Skip to content

Ensures callbacks do not realise data #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
David Flack (daflack) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ensures callbacks do not realise data #1985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8264824
Ensures callbacks do not realise data
daflack Mar 25, 2026
8678403
Converts fix_lfric_cloud_base to lazy data using dask
daflack Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/CSET/operators/read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from pathlib import Path
from typing import Literal

import dask
Copy link
Copy Markdown
Member

@jfrost-mo James Frost (jfrost-mo) Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are now explicitly importing dask we need to add it as a new dependency.

import iris
import iris.coord_systems
import iris.coords
Expand Down Expand Up @@ -789,8 +790,7 @@ def _fix_lfric_cloud_base_altitude(cube: iris.cube.Cube):
varnames = filter(None, [cube.long_name, cube.standard_name, cube.var_name])
if any("cloud_base_altitude" in name for name in varnames):
# Mask cube where set > 144kft to catch default 144.35695538058164
cube.data = np.ma.masked_array(cube.data)
cube.data[cube.data > 144.0] = np.ma.masked
cube.data = dask.array.ma.masked_greater(cube.core_data(), 144.0)


def _fix_um_winds(cubes: iris.cube.CubeList):
Expand Down Expand Up @@ -842,8 +842,8 @@ def _convert_wind_true_dirn_um(cubes: iris.cube.CubeList):
v_grids = cubes.extract(iris.AttributeConstraint(STASH="m01s03i226"))
for u, v in zip(u_grids, v_grids, strict=True):
true_u, true_v = rotate_winds(u, v, iris.coord_systems.GeogCS(6371229.0))
u.data = true_u.data
v.data = true_v.data
u.data = true_u.core_data()
v.data = true_v.core_data()


def _normalise_var0_varname(cube: iris.cube.Cube):
Expand Down
Loading