Ensures callbacks do not realise data#1985
Ensures callbacks do not realise data#1985David Flack (daflack) wants to merge 2 commits intomainfrom
Conversation
Uses the suggestion from Scott Wales in issue 1985, does not close the issue..
|
The cloud base altitude callback alters the function to use that given in #1985 by Scott Wales (@ScottWales) . Does not close #1985. |
|
Thanks, can we have a test showing that |
|
Great idea on the tests for lazy data before and after each callback. I'm just wondering about the data and size (a lot of the test data is currently not lazy when loading directly with iris and no callbacks) so we may need to add new data in a cube for each callback that is lazy. I'll have a chat to James Frost (@jfrost-mo) about this and then start doing the tests. |
James Frost (jfrost-mo)
left a comment
There was a problem hiding this comment.
Looks like a sensible change, and avoiding realizing data would be a great enhancement. I agree that Scott's test suggestion would be a good way to both test this change and to prevent regressions in the callbacks going forwards, so I would like to see it before this is merged.
| from pathlib import Path | ||
| from typing import Literal | ||
|
|
||
| import dask |
There was a problem hiding this comment.
Since we are now explicitly importing dask we need to add it as a new dependency.
Fixes are required to um winds callback for the rotation, and to the cloud base altitude callback.
Fixes #1984
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.