Skip to content

Sdg23 add documentation page#445

Merged
orbeckst merged 8 commits intoMDAnalysis:masterfrom
namiroues:sdg23-add-documentation-page-md
Mar 11, 2025
Merged

Sdg23 add documentation page#445
orbeckst merged 8 commits intoMDAnalysis:masterfrom
namiroues:sdg23-add-documentation-page-md

Conversation

@namiroues
Copy link
Copy Markdown
Contributor

This PR addresses #441.

@namiroues namiroues added the SDG23 work on Small Development Grant 2023 label Mar 10, 2025
@namiroues namiroues self-assigned this Mar 10, 2025
@micaela-matta micaela-matta removed the request for review from orbeckst March 10, 2025 17:22
Copy link
Copy Markdown
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @namiroues, just a few comments.

Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License must be stated correctly, rest of my comments are suggestions for improvements.

@namiroues namiroues removed their assignment Mar 11, 2025
@namiroues
Copy link
Copy Markdown
Contributor Author

Thanks @orbeckst and @RMeli for your comments. I've incorporated the suggested changes.

Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@orbeckst orbeckst self-assigned this Mar 11, 2025
@orbeckst orbeckst merged commit e392102 into MDAnalysis:master Mar 11, 2025
1 check passed
@namiroues namiroues deleted the sdg23-add-documentation-page-md branch April 2, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

3 participants