Skip to content

Sdg23 refine 'learning MDAnalysis' page#444

Merged
micaela-matta merged 3 commits intoMDAnalysis:masterfrom
namiroues:sdg23-update-learning-mdanalysis-md
Mar 25, 2025
Merged

Sdg23 refine 'learning MDAnalysis' page#444
micaela-matta merged 3 commits intoMDAnalysis:masterfrom
namiroues:sdg23-update-learning-mdanalysis-md

Conversation

@namiroues
Copy link
Copy Markdown
Contributor

This PR addresses #441.

@namiroues namiroues self-assigned this Mar 10, 2025
@namiroues namiroues added layout website layout (CSS) SDG23 work on Small Development Grant 2023 and removed layout website layout (CSS) labels Mar 10, 2025
Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my view.

As commented, I'd still mention the papers somewhere.

(And I agree with @micaela-matta to include workshop materials somewhere but I assume you'll address that comment.)

@orbeckst
Copy link
Copy Markdown
Member

@namiroues @micaela-matta have you discussed who is going to eventually merge the PR?

I am asking because @namiroues is assigned to the PR. In the main repo we typically assign the PR to the person who is overseeing review and merging, so I wasn't sure how you wanted to handle it here.

@namiroues namiroues removed their assignment Mar 11, 2025
@namiroues namiroues requested a review from micaela-matta March 12, 2025 14:22
@namiroues
Copy link
Copy Markdown
Contributor Author

@namiroues @micaela-matta have you discussed who is going to eventually merge the PR?

I am asking because @namiroues is assigned to the PR. In the main repo we typically assign the PR to the person who is overseeing review and merging, so I wasn't sure how you wanted to handle it here.

Thanks @orbeckst for the clarification. I unassigned myself from the PR.

@namiroues
Copy link
Copy Markdown
Contributor Author

namiroues commented Mar 12, 2025

Thanks @orbeckst and @micaela-matta for your comments. I restructured the page a bit and look forward to hearing your feedback. :)

Just a comment: The "Tutorials repository" link is missing until this is cleared. This goes on the TODO list.

@jennaswa jennaswa mentioned this pull request Mar 14, 2025
@micaela-matta micaela-matta merged commit 30bdb38 into MDAnalysis:master Mar 25, 2025
1 check passed
@namiroues namiroues deleted the sdg23-update-learning-mdanalysis-md branch April 2, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

3 participants