fix: verify no other compute_2d_mutual_info calls missing minmax#68
Closed
Copilot wants to merge 1 commit intodev-andrea-sifixfrom
Closed
fix: verify no other compute_2d_mutual_info calls missing minmax#68Copilot wants to merge 1 commit intodev-andrea-sifixfrom
Copilot wants to merge 1 commit intodev-andrea-sifixfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix: pass minmax to compute_2d_mutual_info and compute_1d_mutual_info
fix: verify no other compute_2d_mutual_info calls missing minmax
Mar 20, 2026
Member
|
great thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original fix passed
minmaxto allcompute_2d_mutual_infoandcompute_1d_mutual_infocalls inpredictiveNet.py. This follow-up confirms there are no other affected call sites in the repo.Findings
prnn/analysis/,examples/, and the full repo forcompute_2d_mutual_infoandcompute_1d_mutual_infoprnn/utils/predictiveNet.py(lines 845, 865, 882)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.