fix: pass minmax to compute_2d_mutual_info and compute_1d_mutual_info#67
Merged
dlevenstein merged 1 commit intomainfrom Mar 20, 2026
Merged
fix: pass minmax to compute_2d_mutual_info and compute_1d_mutual_info#67dlevenstein merged 1 commit intomainfrom
dlevenstein merged 1 commit intomainfrom
Conversation
SI was computed without minmax, causing incorrect spatial information values. Pass the minmax from env.get_map_bins() and env.get_HD_bins() to all nap.compute_2d_mutual_info and nap.compute_1d_mutual_info calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
thanks! @copilot could you double check if this error is happening anywhere else in the repo (any other compute_2d_mutual_info calls e.g. in analyses?)? |
|
@dlevenstein I've opened a new pull request, #68, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SI was computed without minmax being passed, causing incorrect spatial information values. This fix passes minmax from env.get_map_bins() and env.get_HD_bins() to all nap.compute_2d_mutual_info and nap.compute_1d_mutual_info calls.