Skip to content

Addressing PR comments #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GodWasaProgrammer merged 1 commit into from
Mar 26, 2026
Merged

Addressing PR comments #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions WixInstallerBundle/Bundle.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs"
xmlns:bal="http://wixtoolset.org/schemas/v4/wxs/bal">

<Bundle Id="GWAP.StreamerSocialMediaManager.Bundle"
Name="Streamer Social Media Manager Installer"
<Bundle Id="GWAP.MultistreamManager.Bundle"
Name="Multistream Manager Installer"
Manufacturer="GWAP Technologies"
Version="1.0.0.0">

Expand All @@ -13,10 +13,10 @@
</BootstrapperApplication>

<Chain>
<MsiPackage Name="StreamerSocialMediaManager.msi">
<MsiPackage Name="MultistreamManager.msi" SourceFile="@(ProjectReference->'%(TargetPath)')">
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SourceFile is set to an MSBuild item transform (@(ProjectReference->'%(TargetPath)')), but .wxs files are compiled by WiX and won’t expand MSBuild item syntax. As written, the binder will treat this as a literal path and the bundle build is likely to fail or not pick up the MSI. Use a WiX-resolvable path/variable for the referenced project's output (e.g., a $(var...) value exposed by the WiX SDK for the WixPackage ProjectReference, or pass the MSI path in via DefineConstants from the .wixproj).

Suggested change
<MsiPackage Name="MultistreamManager.msi" SourceFile="@(ProjectReference->'%(TargetPath)')">
<MsiPackage Name="MultistreamManager.msi" SourceFile="$(var.MultistreamManagerMsi)">

Copilot uses AI. Check for mistakes.
<MsiProperty Name="INSTALLFOLDER" Value="[InstallFolder]" />
</MsiPackage>
</Chain>

</Bundle>
</Wix>
</Wix>
3 changes: 2 additions & 1 deletion WixInstallerBundle/WixInstallerBundle.wixproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="WixToolset.Sdk/6.0.2">

<PropertyGroup>
<OutputName>MultistreamManagerInstaller</OutputName>
<OutputType>Bundle</OutputType>
</PropertyGroup>

Expand Down Expand Up @@ -34,4 +35,4 @@
<WixBundlePayload Include="@(ResolvedMSI)" />
</ItemGroup>

</Project>
</Project>
Loading