Skip to content

Addressing PR comments#35

Merged
GodWasaProgrammer merged 1 commit intomasterfrom
codex/fix-wixinstallerbundle-file-issue
Mar 26, 2026
Merged

Addressing PR comments#35
GodWasaProgrammer merged 1 commit intomasterfrom
codex/fix-wixinstallerbundle-file-issue

Conversation

@Codex
Copy link
Copy Markdown
Contributor

@Codex Codex AI commented Mar 26, 2026

No description provided.

Co-authored-by: GodWasaProgrammer <72033235+GodWasaProgrammer@users.noreply.github.com>
Copy link
Copy Markdown
Owner

@GodWasaProgrammer GodWasaProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but since it is the Bundle that gets delivered to customer - does this actually give the user a shortcut?

@Codex
Copy link
Copy Markdown
Contributor Author

Codex AI commented Mar 26, 2026

Okay, but since it is the Bundle that gets delivered to customer - does this actually give the user a shortcut?

The bundle installs the MSI, and the MSI already defines the Desktop and Start Menu shortcuts (ShortcutComponents in WixPackage/Shortcuts.wxs). By pointing the bundle to the correct MultistreamManager.msi (commit f8f5365), those shortcuts are delivered to the user.

@Codex Codex AI changed the title Align bundle payload with Multistream Manager MSI Addressing PR comments Mar 26, 2026
@Codex Codex AI requested a review from GodWasaProgrammer March 26, 2026 20:35
@GodWasaProgrammer GodWasaProgrammer marked this pull request as ready for review March 26, 2026 20:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the WiX installer bundle to match the current “Multistream Manager” branding and ensures the bundle ships the correct MSI produced by the WixPackage project.

Changes:

  • Renames the bundle Id/Name from Streamer Social Media Manager to Multistream Manager.
  • Updates the bundle chain to reference MultistreamManager.msi.
  • Sets the bundle project OutputName to MultistreamManagerInstaller.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
WixInstallerBundle/WixInstallerBundle.wixproj Sets the bundle output artifact name to MultistreamManagerInstaller.
WixInstallerBundle/Bundle.wxs Updates bundle identity strings and changes the chained MSI package name/source.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


<Chain>
<MsiPackage Name="StreamerSocialMediaManager.msi">
<MsiPackage Name="MultistreamManager.msi" SourceFile="@(ProjectReference->'%(TargetPath)')">
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SourceFile is set to an MSBuild item transform (@(ProjectReference->'%(TargetPath)')), but .wxs files are compiled by WiX and won’t expand MSBuild item syntax. As written, the binder will treat this as a literal path and the bundle build is likely to fail or not pick up the MSI. Use a WiX-resolvable path/variable for the referenced project's output (e.g., a $(var...) value exposed by the WiX SDK for the WixPackage ProjectReference, or pass the MSI path in via DefineConstants from the .wixproj).

Suggested change
<MsiPackage Name="MultistreamManager.msi" SourceFile="@(ProjectReference->'%(TargetPath)')">
<MsiPackage Name="MultistreamManager.msi" SourceFile="$(var.MultistreamManagerMsi)">

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner

@GodWasaProgrammer GodWasaProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the End User gets the bundle - is the shortcuts actually created?

@Codex
Copy link
Copy Markdown
Contributor Author

Codex AI commented Mar 26, 2026

since the End User gets the bundle - is the shortcuts actually created?

Yes. The bundle just delivers the MSI, and the MSI already creates the Desktop and Start Menu shortcuts defined in WixPackage/Shortcuts.wxs (DesktopShortcut/StartMenuShortcut in ShortcutComponents).

@Codex Codex AI requested a review from GodWasaProgrammer March 26, 2026 20:38
@GodWasaProgrammer GodWasaProgrammer merged commit fcd3e7b into master Mar 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants