Conversation
Co-authored-by: GodWasaProgrammer <72033235+GodWasaProgrammer@users.noreply.github.com>
GodWasaProgrammer
left a comment
There was a problem hiding this comment.
Okay, but since it is the Bundle that gets delivered to customer - does this actually give the user a shortcut?
The bundle installs the MSI, and the MSI already defines the Desktop and Start Menu shortcuts (ShortcutComponents in WixPackage/Shortcuts.wxs). By pointing the bundle to the correct MultistreamManager.msi (commit f8f5365), those shortcuts are delivered to the user. |
There was a problem hiding this comment.
Pull request overview
Updates the WiX installer bundle to match the current “Multistream Manager” branding and ensures the bundle ships the correct MSI produced by the WixPackage project.
Changes:
- Renames the bundle
Id/Namefrom Streamer Social Media Manager to Multistream Manager. - Updates the bundle chain to reference
MultistreamManager.msi. - Sets the bundle project
OutputNametoMultistreamManagerInstaller.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WixInstallerBundle/WixInstallerBundle.wixproj | Sets the bundle output artifact name to MultistreamManagerInstaller. |
| WixInstallerBundle/Bundle.wxs | Updates bundle identity strings and changes the chained MSI package name/source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <Chain> | ||
| <MsiPackage Name="StreamerSocialMediaManager.msi"> | ||
| <MsiPackage Name="MultistreamManager.msi" SourceFile="@(ProjectReference->'%(TargetPath)')"> |
There was a problem hiding this comment.
SourceFile is set to an MSBuild item transform (@(ProjectReference->'%(TargetPath)')), but .wxs files are compiled by WiX and won’t expand MSBuild item syntax. As written, the binder will treat this as a literal path and the bundle build is likely to fail or not pick up the MSI. Use a WiX-resolvable path/variable for the referenced project's output (e.g., a $(var...) value exposed by the WiX SDK for the WixPackage ProjectReference, or pass the MSI path in via DefineConstants from the .wixproj).
| <MsiPackage Name="MultistreamManager.msi" SourceFile="@(ProjectReference->'%(TargetPath)')"> | |
| <MsiPackage Name="MultistreamManager.msi" SourceFile="$(var.MultistreamManagerMsi)"> |
GodWasaProgrammer
left a comment
There was a problem hiding this comment.
since the End User gets the bundle - is the shortcuts actually created?
Yes. The bundle just delivers the MSI, and the MSI already creates the Desktop and Start Menu shortcuts defined in WixPackage/Shortcuts.wxs (DesktopShortcut/StartMenuShortcut in ShortcutComponents). |
No description provided.