fix: correct TalentMap indices for all classes (#21)#22
Merged
Conversation
Verified all TalentMap talent positions (tab:index) against in-game GetTalentInfo output on TBC Anniversary client (1.15.x). Classes corrected (key changes): - Priest: 7 of 8 entries - Warrior: 10 of 11 entries + deferred comments - Rogue: 15 of 17 entries + deferred comments - Paladin: 8 of 9 entries Classes verified correct (docs only): - Mage: all 21 entries already correct - Druid: all 19 entries already correct - Shaman: all 12 entries already correct All files now include grid layout documentation showing the full talent tree ordered by internal talentID, matching the in-game API. Also fixed .busted config pattern from '_spec' to 'test_' to match actual test file naming convention.
9 tasks
Updated test files (test_modifiercalc, test_critcalc, test_new_spells, test_pipeline) to use reindexed Warlock TalentMap keys from PR #19. Fixed Master Demonologist talentAmplify.talentKey in AuraMap_Warlock from 2:16 (Soul Link) to 2:11 (Master Demonologist).
- Extract shared Format module (colors, symbols, FormatNumber, FormatDPS) - Add spell name and rank header line with school-colored text - Restore labeled detail lines (Coeff, Cast, Talents, Stats, Breakdown) - Hide 0% crit for DoT-only spells - Use directCoefficient/dotCoefficient for safe hybrid display - Replace non-rendering Unicode escapes with ASCII alternatives - Deduplicate FormatNumber between Tooltip and ActionBar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verified and corrected all TalentMap talent positions (
tab:index) for every supported class against in-gameGetTalentInfooutput on TBC Anniversary client (1.15.x). TBC Anniversary reorders talents by internaltalentIDrather than visual grid position, causing many talent lookups to silently fail.Four classes had incorrect indices: Priest (7/8 entries), Warrior (10/11), Rogue (15/17), and Paladin (8/9). Three classes (Mage, Druid, Shaman) were already correct and received documentation-only updates with grid layout comments.
All TalentMap files now include full grid layout documentation showing the talent tree ordered by internal talentID, matching the in-game API.
Also fixed the
.bustedconfig pattern from_spectotest_to match the actual test file naming convention, and updated all test files to use the corrected talent keys.Closes #21
Type of Change
Related Issues
Fixes #21
Testing
luacheck .) - 0 warnings / 0 errors in 74 filesChecklist