Skip to content

[Bug]: TalentMap indices incorrect for all classes on TBC Anniversary #21

@Xerrion

Description

@Xerrion

Game version

TBC Anniversary (2.5.5) on 1.15.x unified Classic client

Description

The TBC Anniversary client orders talents by internal talentID rather than the row/column grid position used by the old TBC Classic client. All TalentMap files were built using row/column sequential numbering from Wowhead, so the indices are wrong for every class.

Issue #12 fixed the runtime behavior by adding name-based talent matching in StateCollector.CollectTalents, making the addon immune to index reordering. However, the TalentMap data files still contain incorrect indices as documentation.

Affected classes

  • Warlock - fixed in fix: name-based talent matching for TBC Anniversary index reordering #19
  • Hunter - verified in-game, all 10 entries wrong
  • Mage - needs in-game verification
  • Priest - needs in-game verification
  • Warrior - needs in-game verification
  • Rogue - needs in-game verification (has grid docs but likely wrong ordering)
  • Druid - needs in-game verification
  • Shaman - needs in-game verification
  • Paladin - needs in-game verification

Impact

Low - name-based matching handles this at runtime. This is a documentation/correctness fix. The TalentMap keys should match what GetTalentInfo(tab, index) returns in-game so developers can verify with /dump.

Steps to reproduce

Run on any class:

/run for t=1,3 do for i=1,30 do local n,_,_,_,r,m=GetTalentInfo(t,i) if n then print(t..':'..i..' '..n..' '..r..'/'..m) end end end

Compare output against the TalentMap data file for that class.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions