Skip to content

Remove unsafeLogUnredactedQueries for now#583

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/sub-pr-580
Draft

Remove unsafeLogUnredactedQueries for now#583
Copilot wants to merge 4 commits intomainfrom
copilot/sub-pr-580

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

Removes the unsafeLogUnredactedQueries config toggle and stops logging query text and URL search params entirely — no opt-in, no leakage.

Summary

  • Removed unsafeLogUnredactedQueries from public config types and all connection param wiring
  • Debug logs no longer include raw query= in request_params (always redacted via clone + delete)
  • Error logs no longer include search_params at all
  • Added regression test asserting sensitive query parameter binding values (param_<name>=<value>) never appear in any log entry, even at TRACE level and under connection failure conditions

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Remove unsafeLogUnredactedQueries for now Remove unsafeLogUnredactedQueries for now Feb 26, 2026
@peter-leonov-ch peter-leonov-ch force-pushed the postpone_unsafe_query branch 2 times, most recently from 38ebd96 to b6ce135 Compare February 27, 2026 12:34
Base automatically changed from postpone_unsafe_query to main March 2, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants