Remove unsafeLogUnredactedQueries for now#580
Merged
peter-leonov-ch merged 7 commits intomainfrom Mar 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unsafeLogUnredactedQueries configuration option across the common + Node clients so query text is no longer emitted in logs, and URL query search params are always redacted when logging request context.
Changes:
- Removed
unsafeLogUnredactedQueriesfrom public config/types and connection params wiring. - Stopped including raw
queryin structured logargs(client + node connection lifecycle logs). - Always deletes
queryfrom URL/search params before logging (debug/error contexts), and deletes now-obsolete tests/docs.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/client-node/src/connection/node_base_connection.ts | Removes query text from logs and always redacts query from logged URL/search params. |
| packages/client-node/tests/utils/http_stubs.ts | Removes the deprecated config field from test connection params. |
| packages/client-node/tests/unit/node_client.test.ts | Removes the deprecated config field from unit test client config. |
| packages/client-node/tests/integration/node_logger_support.test.ts | Removes tests that exercised the unsafe toggle. |
| packages/client-common/src/connection.ts | Removes unsafeLogUnredactedQueries from the ConnectionParams interface. |
| packages/client-common/src/config.ts | Removes the public config option and stops mapping it into connection params. |
| packages/client-common/src/client.ts | Stops including query text in structured logs at the client layer. |
| packages/client-common/tests/utils/client.ts | Removes test-only config that depended on the unsafe toggle. |
| packages/client-common/tests/unit/config.test.ts | Updates expected connection params object to no longer include the removed field. |
| CHANGELOG.md | Removes documentation mentioning the unsafe logging toggle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peter-leonov-ch
force-pushed
the
postpone_unsafe_query
branch
2 times, most recently
from
8912cf7 to
3e0cfdd
Compare
peter-leonov-ch
commented
Feb 26, 2026
peter-leonov-ch
force-pushed
the
postpone_unsafe_query
branch
2 times, most recently
from
6b35c38 to
46ef34a
Compare
Collaborator
Author
|
@copilot review risks this PR can introduce. |
3 tasks
Contributor
|
@peter-leonov-ch I've opened a new pull request, #583, to work on those changes. Once the pull request is ready, I'll request review from you. |
peter-leonov-ch
force-pushed
the
postpone_unsafe_query
branch
from
e87af82 to
64fdfc8
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> polish the test
peter-leonov-ch
force-pushed
the
postpone_unsafe_query
branch
from
64fdfc8 to
38ebd96
Compare
peter-leonov-ch
force-pushed
the
postpone_unsafe_query
branch
from
38ebd96 to
b6ce135
Compare
Collaborator
Author
|
Addressed risk analysis from: |
mshustov
reviewed
Feb 27, 2026
| }), | ||
| ).rejects.toThrow() // We expect this to fail since the query is invalid, but we want to check the logs | ||
| for (const entry of logs) { | ||
| expect(entry.message).not.toContain(secret) |
Member
There was a problem hiding this comment.
do we need to add an explicit test for query itself?
Collaborator
Author
There was a problem hiding this comment.
Fair point, added.
mshustov
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unsafeLogUnredactedQueriestoggle from the code