Skip to content

don't check lastTarget autoHoldDropped if it was not held #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dooly123 merged 1 commit into from
Mar 8, 2026
Merged

don't check lastTarget autoHoldDropped if it was not held #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Basis/Packages/com.basis.framework/Interactions/BasisPlayerInteract.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,9 @@ private void UpdatePickupState(BasisInteractableObject hitInteractable, ref Basi
// Not pressing interact: clear states from last target (if needed), then consider hover on new target.
bool removeTarget = false;

bool lastTargetIsHeld = interactInput.lastTarget.IsInteractingWith(interactInput.input);
bool autoHoldDropped = true;
if (IsDesktopCenterEye(interactInput.input))
if (lastTargetIsHeld && IsDesktopCenterEye(interactInput.input))
{
autoHoldDropped =
interactInput.lastTarget.AutoHold != BasisAutoHold.Yes ||
Expand Down
Loading