fix: pass LANDO_HOST_xID vars to initOnly services#2764
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses local dev environment permission failures for initOnly containers by ensuring host UID/GID information is available to those services during initialization, preventing empty LANDO_HOST_UID/LANDO_HOST_GID values and the resulting user/group remapping errors.
Changes:
- Bump the local dev environment version to trigger updates for existing environments.
- Pass
LANDO_HOST_UID/LANDO_HOST_GIDintoinitOnlyservices in the Lando template so permission scripts can correctly map users/groups.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/constants/dev-environment.ts | Bumps DEV_ENVIRONMENT_VERSION to 2.3.3 to roll forward local env updates. |
| assets/dev-env.lando.template.yml.ejs | Injects LANDO_HOST_UID/LANDO_HOST_GID into relevant initOnly services to fix permissions remapping. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR solves the issue with permissions like this:
Changelog Description
Fixed
initOnlycontainersPull request checklist
New release checklist
Steps to Test
Wuth this PR applied, the permission sweep must succeed:
The issues with missing
chshorgetentwill be addressed in Automattic/lando-cli