Skip to content

fix(streaming): reject connect promise on socket error or close #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mostafaroshdy1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(streaming): reject connect promise on socket error or close #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/services/streaming/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export class StreamingTranscriber {
}

connect() {
return new Promise<BeginEvent>((resolve) => {
return new Promise<BeginEvent>((resolve, reject) => {
if (this.socket) {
throw new Error("Already connected");
}
Expand All @@ -226,6 +226,11 @@ Learn more at https://github.com/AssemblyAI/assemblyai-node-sdk/blob/main/docs/c
this.socket.onopen = () => {};

this.socket.onclose = ({ code, reason }: CloseEvent) => {
reject(
new Error(
`Connection closed before session started. Code: ${code}, Reason: ${reason}`,
),
);
if (!reason) {
if (code in StreamingErrorMessages) {
reason = StreamingErrorMessages[code as StreamingErrorTypeCodes];
Expand All @@ -235,8 +240,9 @@ Learn more at https://github.com/AssemblyAI/assemblyai-node-sdk/blob/main/docs/c
};

this.socket.onerror = (event: ErrorEvent) => {
if (event.error) this.listeners.error?.(event.error as Error);
else this.listeners.error?.(new Error(event.message));
const error = event.error || new Error(event.message);
reject(error);
this.listeners.error?.(error);
};

this.socket.onmessage = ({ data }: MessageEvent) => {
Expand Down