fix(streaming): reject connect promise on socket error or close#137
Open
mostafaroshdy1 wants to merge 1 commit intoAssemblyAI:mainfrom
Open
fix(streaming): reject connect promise on socket error or close#137mostafaroshdy1 wants to merge 1 commit intoAssemblyAI:mainfrom
mostafaroshdy1 wants to merge 1 commit intoAssemblyAI:mainfrom
Conversation
Ensures the StreamingTranscriber.connect() promise does not hang indefinitely if the WebSocket fails to initialize. - Added reject() calls to onerror and onclose handlers. - Added reject() to onmessage if an application-level error is received. - Fixes issue where DNS failures (ENOTFOUND) cause the process to hang or crash without a catchable error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the StreamingTranscriber.connect() promise does not hang indefinitely if the WebSocket fails to initialize.
if you see a better approach to handle this kind of issues , feel free to drop a comment
#136