added method get_translations(field_name)#7
Open
amirnissim wants to merge 2 commits intozmathew:masterfrom
Open
added method get_translations(field_name)#7amirnissim wants to merge 2 commits intozmathew:masterfrom
amirnissim wants to merge 2 commits intozmathew:masterfrom
Conversation
linguo/models.py
Outdated
Owner
There was a problem hiding this comment.
I wonder if we should return a dict mapping language to translation instead. Otherwise it could be ambiguous as to which language a translation belong to.
For example, if you have languages en and fr (in that order), but you don't have a translation for 'en'. get_translations will return ['something'] but you won't know which language that is.
Author
|
@zmathew obj.get_translations('name').values()
-> ['English_name', 'French_name']and it is now easy to test if there is a translation for a language: 'en' in obj.get_translations('name')
-> True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful for checking user entered input against all translations of a translatable field