Skip to content

addon: add const overloads for multipart_t front/back #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gummif merged 2 commits into from
Mar 18, 2026
Merged

addon: add const overloads for multipart_t front/back #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b69587
addon: add const overloads for multipart_t front/back
mberk-yilmaz Mar 18, 2026
1d691c2
fix: applied clang-format to fix style. No functional changes.
mberk-yilmaz Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions tests/multipart.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include <catch2/catch_all.hpp>
#include <zmq_addon.hpp>

#include <utility>

#ifdef ZMQ_HAS_RVALUE_REFS

#ifdef ZMQ_CPP17
Expand All @@ -17,6 +19,19 @@ static_assert(std::is_invocable<decltype(&zmq::multipart_t::recv),
#endif
static_assert(std::is_constructible<zmq::multipart_t, zmq::socket_ref>::value,
"Can't construct with socket_ref");
static_assert(std::is_same<decltype(std::declval<zmq::multipart_t &>().front()),
const zmq::message_t &>::value,
"multipart_t::front() should keep returning const message_t&");
static_assert(
std::is_same<decltype(std::declval<const zmq::multipart_t &>().front()),
const zmq::message_t &>::value,
"multipart_t::front() const should return const message_t&");
static_assert(std::is_same<decltype(std::declval<zmq::multipart_t &>().back()),
const zmq::message_t &>::value,
"multipart_t::back() should keep returning const message_t&");
static_assert(std::is_same<decltype(std::declval<const zmq::multipart_t &>().back()),
const zmq::message_t &>::value,
"multipart_t::back() const should return const message_t&");

/// \todo split this up into separate test cases
///
Expand Down Expand Up @@ -106,11 +121,18 @@ TEST_CASE("multipart legacy test", "[multipart]")
multipart.pushmem("Frame0", 6);
assert(multipart.size() == 10);

const message_t &front_msg = multipart.front();
const message_t &front_msg_nonconst = multipart.front();
assert(&front_msg_nonconst == &multipart[0]);

const multipart_t &const_multipart = multipart;
const message_t &front_msg = const_multipart.front();
assert(multipart.size() == 10);
assert(std::string(front_msg.data<char>(), front_msg.size()) == "Frame0");

const message_t &back_msg = multipart.back();
const message_t &back_msg_nonconst = multipart.back();
assert(&back_msg_nonconst == &multipart[multipart.size() - 1]);

const message_t &back_msg = const_multipart.back();
assert(multipart.size() == 10);
assert(std::string(back_msg.data<char>(), back_msg.size()) == "Frame9");

Expand Down
6 changes: 6 additions & 0 deletions zmq_addon.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,9 +594,15 @@ class multipart_t
// get message part from front
const message_t &front() { return m_parts.front(); }

// get message part from front
const message_t &front() const { return m_parts.front(); }

// get message part from back
const message_t &back() { return m_parts.back(); }

// get message part from back
const message_t &back() const { return m_parts.back(); }

// Get pointer to a specific message part
const message_t *peek(size_t index) const { return &m_parts[index]; }

Expand Down
Loading