Highlight case keyword in if-case expressions#76
Open
fatalaa wants to merge 1 commit intozed-extensions:mainfrom
Open
Highlight case keyword in if-case expressions#76fatalaa wants to merge 1 commit intozed-extensions:mainfrom
case keyword in if-case expressions#76fatalaa wants to merge 1 commit intozed-extensions:mainfrom
Conversation
The tree-sitter grammar parses `case` in if-case patterns (e.g., `if (x case String value)`) as an anonymous `"case"` node, unlike switch statements which use the named `case_builtin` node. This meant `case` was unhighlighted in if-case expressions. Add `"case"` to the `@keyword.conditional` group alongside `if`, `else`, `switch`, and `default`. Fixes part of zed-extensions#29
|
We require contributors to sign our Contributor License Agreement, and we don't have @fatalaa on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree-sitter grammar parses
casein if-case patterns (e.g.,if (x case String value)) as an anonymous"case"node, unlike switch statements which use the namedcase_builtinnode. This meantcasewas unhighlighted in if-case expressions.Add
"case"to the@keyword.conditionalgroup alongsideif,else,switch, anddefault.Fixes part of #29